Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rubocop channel to fix codeclimate issue related to rubocop #150

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

ashwinisukale
Copy link
Contributor

@ashwinisukale ashwinisukale commented Nov 30, 2023

codeclimate/codeclimate-rubocop#178

they suggest to use this channel to fix this issue.

Purpose

closes: #148

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@ashwinisukale ashwinisukale requested a review from a team November 30, 2023 12:08
@ashwinisukale ashwinisukale merged commit 4c5d29f into master Nov 30, 2023
2 checks passed
@ashwinisukale ashwinisukale deleted the codeclimate_fix branch November 30, 2023 12:16
@ashwinisukale ashwinisukale self-assigned this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix codeclimate error
2 participants