Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not send events to the event busy unless datacite_crossref #191

Merged
merged 4 commits into from
Oct 28, 2024
Merged

do not send events to the event busy unless datacite_crossref #191

merged 4 commits into from
Oct 28, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

Purpose

closes: #190

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

digitaldogsbody
digitaldogsbody approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Wendel!

spec/models/related_identifier_spec.rb Outdated Show resolved Hide resolved
@digitaldogsbody
Copy link
Member

I made one other small change to the test description, but now I can't approve because I am the last committer 🫠

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team October 28, 2024 08:03
@wendelfabianchinsamy
Copy link
Contributor Author

I made one other small change to the test description, but now I can't approve because I am the last committer 🫠

Lol thanks Mike. Mondays, am i right 🤣

@wendelfabianchinsamy wendelfabianchinsamy merged commit 6850321 into master Oct 28, 2024
2 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the stop-sending-datacite-to-datacite-events-to-data-bus branch October 28, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitaldogsbody digitaldogsbody digitaldogsbody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop sending DataCite <-> DataCite events to the Event Data Bus
2 participants
@wendelfabianchinsamy @digitaldogsbody