Data Diffs with No Primary Key in CI #98
Open
+15
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2023 12:22
![datafold[bot]](https://avatars.githubusercontent.com/in/103851?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Base branch | Pull Request branch |
| master (1986a36) | demo/no-primary-key (99321df) |
Data Diffs of tables modified in this pull request: ⚠️ 1, 1
| DEMO.CORE.DIM_ORGS | ||||||
| master | demo/no-primary-key | |||||
| DIFFERENCES | ||||||
| Total rows | 157 | ↓ 146 -7.0% | ||||
NO DIFFERENCES IN ROW COUNT AND SCHEMA
|
||||||
| Data app dependencies | ||||||
looker — 4
|
||||||
hightouch — 1
|
||||||
| View details → | ||||||
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | demo/no-primary-key | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↓ 3 -25.0% | ||||||||||||
| Exclusive PKs | 2 | 1 | ||||||||||||
NO DIFFERENCES
|
||||||||||||||
| Data app dependencies | ||||||||||||||
hightouch — 1
|
||||||||||||||
| View details → | ||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
sungchun12
changed the title
There was a problem hiding this comment.
| Base branch | Pull Request branch |
| master (1986a36) | demo/no-primary-key (99321df) |
Data Diffs of tables modified in this pull request: ⚠️ 1, 1
| DEMO.CORE.DIM_ORGS | ||||||
| master | demo/no-primary-key | |||||
| DIFFERENCES | ||||||
| Total rows | 157 | ↓ 146 -7.0% | ||||
NO DIFFERENCES IN ROW COUNT AND SCHEMA
|
||||||
| Data app dependencies | ||||||
looker — 4
|
||||||
hightouch — 1
|
||||||
| View details → | ||||||
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | demo/no-primary-key | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↓ 3 -25.0% | ||||||||||||
| Exclusive PKs | 2 | 1 | ||||||||||||
NO DIFFERENCES
|
||||||||||||||
| Data app dependencies | ||||||||||||||
hightouch — 1
|
||||||||||||||
| View details → | ||||||||||||||
Data Diffs of downstream tables: ⚠️ 2
| DEMO.CORE.FCT_MONTHLY_FINANCIALS | ||||||
| master | demo/no-primary-key | |||||
| DIFFERENCES | ||||||
| Total rows | 6 | ↓ 5 -16.7% | ||||
NO DIFFERENCES IN ROW COUNT AND SCHEMA
|
||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||
| Data app dependencies | ||||||
looker — 4
|
||||||
| View details → | ||||||
| DEMO.CORE.FCT_YEARLY_FINANCIALS | ||||||||
NO DIFFERENCES IN ROW COUNT AND SCHEMA
|
||||||||
Modified upstream modelsmodel.demo.dim_orgs |
||||||||
| View details → | ||||||||
There was a problem hiding this comment.
| Base branch | Pull Request branch |
| master (47c7dc6) | demo/no-primary-key (99321df) |
Data Diffs of tables modified in this pull request: ⚠️ 1, 1
| DEMO.CORE.DIM_ORGS | ||||||
| master | demo/no-primary-key | |||||
| DIFFERENCES | ||||||
| Total rows | 157 | ↓ 146 -7.0% | ||||
NO DIFFERENCES
|
||||||
| View details → | ||||||
| DEMO.CORE.SALES_SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
| master | demo/no-primary-key | |||||||||||||
| DIFFERENCES | ||||||||||||||
| Total rows | 4 | ↓ 3 -25.0% | ||||||||||||
| Exclusive PKs | 2 | 1 | ||||||||||||
NO DIFFERENCES
|
||||||||||||||
| Data app dependencies | ||||||||||||||
Hightouch — 1
|
||||||||||||||
| View details → | ||||||||||||||
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables| DEMO.CORE.fct_monthly_financials (table) | Run Data Diff → |
| DEMO.CORE.fct_yearly_financials (table) | Run Data Diff → |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.