Update default API URL in the webap #860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbocarsly
force-pushed
the
jdb/update-default-server-port
branch
from
a36243b
to
87417b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 62 62
Lines 3884 3884
=======================================
Hits 2646 2646
Misses 1238 1238 |
datalab
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
jdb/update-default-server-port
|
| Run status |
|
| Run duration | 02m 34s |
| Commit |
|
| Committer | Josh Bocarsly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
12
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
117
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
batchSampleFeature.cy.js • 1 failed test • End-to-end tests (chrome)
| Test | Artifacts | |
|---|---|---|
| Batch sample creation > Adds 3 valid samples |
Test Replay
Screenshots
|
|
editPage.cy.js • 1 failed test • End-to-end tests (chrome)
| Test | Artifacts | |
|---|---|---|
| Edit Page > Loads the main page without any errors |
Test Replay
Screenshots
|
|
equipment.cy.js • 1 failed test • End-to-end tests (chrome)
| Test | Artifacts | |
|---|---|---|
| Equipment table page > Loads the equipment page without any errors |
Test Replay
Screenshots
|
|
sampleTablePage.cy.js • 1 failed test • End-to-end tests (chrome)
| Test | Artifacts | |
|---|---|---|
| Advanced sample creation features > Adds some valid samples |
Test Replay
Screenshots
|
|
batchSampleFeature.cy.js • 1 failed test • End-to-end tests (electron)
| Test | Artifacts | |
|---|---|---|
| Batch sample creation > Adds 3 valid samples |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pydatalab is run in the default development manner (i.e., with
flask run), it now serves the API tohttp://localhost:5000. However, the webapp still defaults to sending the requests tohttp://localhost:5001.This pull request updates the default tohttp://localhost:5000.Note that the API URL can always be configured in the
.envfiles of the webapp and will supercede this default value.