-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for DataTable Prime components #884
Draft
BenjaminCharmes
wants to merge
2
commits into
main
Choose a base branch
from
bc/components_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 62 62
Lines 3941 3941
=======================================
Hits 2695 2695
Misses 1246 1246 |
BenjaminCharmes
force-pushed
the
bc/components_test
branch
from
September 24, 2024 13:14
9dfc4f6
to
50ee1d9
Compare
BenjaminCharmes
force-pushed
the
bc/components_test
branch
from
September 26, 2024 15:43
5d6bc68
to
fcd512b
Compare
BenjaminCharmes
force-pushed
the
bc/components_test
branch
2 times, most recently
from
October 4, 2024 16:13
fef8c4c
to
404af58
Compare
BenjaminCharmes
force-pushed
the
bc/components_test
branch
from
October 4, 2024 16:30
0521cec
to
53451c4
Compare
BenjaminCharmes
force-pushed
the
bc/components_test
branch
from
October 4, 2024 16:40
23dfa9e
to
16f8c73
Compare
BenjaminCharmes
added
testing
For issues/PRs that change how the package is tested
API
For issues/PRs pertaining to the API
webapp
For issues/PRs pertaining to the web interface
labels
Oct 8, 2024
ml-evs
force-pushed
the
bc/components_test
branch
from
October 17, 2024 11:37
16f8c73
to
3043fe2
Compare
ml-evs
force-pushed
the
bc/components_test
branch
from
November 6, 2024 15:24
3043fe2
to
22da19f
Compare
ml-evs
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think this is basically ready to merge from my side, once the tests are passing again. We can then start adding more incrementally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#794 & #889
Add component test for:
Add e2e test for: