Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for DataTable Prime components #884

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 24, 2024

#794 & #889

Add component test for:

  • SampleTable
  • CollectionTable
  • EquipmentTable
  • StartingMaterialTable

Add e2e test for:

  • startingMaterial

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (3230bb2) to head (22da19f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          62       62           
  Lines        3941     3941           
=======================================
  Hits         2695     2695           
  Misses       1246     1246           

Copy link

cypress bot commented Sep 24, 2024

datalab    Run #2733

Run Properties:  status check failed Failed #2733  •  git commit 302a7824f6 ℹ️: Merge 22da19f5bb4e9e11227099aa5c977cd7ac4a6b27 into 3230bb23fa9c9805ab56608a1717...
Project datalab
Branch Review bc/components_test
Run status status check failed Failed #2733
Run duration 07m 21s
Commit git commit 302a7824f6 ℹ️: Merge 22da19f5bb4e9e11227099aa5c977cd7ac4a6b27 into 3230bb23fa9c9805ab56608a1717...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 30
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 141
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/startingMaterial.cy.js • 10 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Starting material table page > Loads the Starting material page without any errors Test Replay Screenshots
Starting material table page > Adds some valid starting material entries Test Replay Screenshots
Starting material table page > Checks if one of the starting material is in the database Test Replay Screenshots
Starting material table page > Attempts to Add a starting material with the same name Test Replay Screenshots
Starting material table page > Deletes a starting material Test Replay Screenshots
Starting material table page > copies a starting material entry Test Replay Screenshots
Starting material edit page > Checks the equipment edit page Test Replay Screenshots
Starting material edit page > modifies some data in a starting material Test Replay Screenshots
Starting material table page - editable_inventory FALSE > Does not allow adding starting materials Test Replay Screenshots
Starting material table page - editable_inventory FALSE > Does not allow modifying existing starting materials Test Replay Screenshots
Failed  cypress/e2e/startingMaterial.cy.js • 10 failed tests • End-to-end tests (firefox)

View Output

Test Artifacts
Starting material table page > Loads the Starting material page without any errors Screenshots
Starting material table page > Adds some valid starting material entries Screenshots
Starting material table page > Checks if one of the starting material is in the database Screenshots
Starting material table page > Attempts to Add a starting material with the same name Screenshots
Starting material table page > Deletes a starting material Screenshots
Starting material table page > copies a starting material entry Screenshots
Starting material edit page > Checks the equipment edit page Screenshots
Starting material edit page > modifies some data in a starting material Screenshots
Starting material table page - editable_inventory FALSE > Does not allow adding starting materials Screenshots
Starting material table page - editable_inventory FALSE > Does not allow modifying existing starting materials Screenshots
Failed  cypress/e2e/startingMaterial.cy.js • 10 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Starting material table page > Loads the Starting material page without any errors Test Replay Screenshots
Starting material table page > Adds some valid starting material entries Test Replay Screenshots
Starting material table page > Checks if one of the starting material is in the database Test Replay Screenshots
Starting material table page > Attempts to Add a starting material with the same name Test Replay Screenshots
Starting material table page > Deletes a starting material Test Replay Screenshots
Starting material table page > copies a starting material entry Test Replay Screenshots
Starting material edit page > Checks the equipment edit page Test Replay Screenshots
Starting material edit page > modifies some data in a starting material Test Replay Screenshots
Starting material table page - editable_inventory FALSE > Does not allow adding starting materials Test Replay Screenshots
Starting material table page - editable_inventory FALSE > Does not allow modifying existing starting materials Test Replay Screenshots

@BenjaminCharmes BenjaminCharmes force-pushed the bc/components_test branch 2 times, most recently from fef8c4c to 404af58 Compare October 4, 2024 16:13
@ml-evs ml-evs added this to the v0.5.x milestone Oct 8, 2024
@BenjaminCharmes BenjaminCharmes added testing For issues/PRs that change how the package is tested API For issues/PRs pertaining to the API webapp For issues/PRs pertaining to the web interface labels Oct 8, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this is basically ready to merge from my side, once the tests are passing again. We can then start adding more incrementally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API For issues/PRs pertaining to the API testing For issues/PRs that change how the package is tested webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants