[#109] Exploratory work for providing map interface on top of datalevin#200
Draft
ieugen wants to merge 4 commits intodatalevin:masterfrom
Draft
[#109] Exploratory work for providing map interface on top of datalevin#200ieugen wants to merge 4 commits intodatalevin:masterfrom
ieugen wants to merge 4 commits intodatalevin:masterfrom
Conversation
08e7def to
d643881
Compare
Contributor
Author
|
I have added code to test the map implementation using guava collection test. For guava test cases There are a lot of more tests to run and for more data-types. Things are shaping up nicely @huahaiy :) |
…on top of datalevin
* implemented AutoCloseable close * implemented Map clear, size, containsValue, isEmpty
* We need more infrastructure to test this
dc7c141 to
24c427b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exploratory work.
So far it can live outside datalevin.
Once it's fully implemented, I think it should be part of datalevin because it can be plugged in into existing API's that support Map.
It can also provide a way for users to use datalevin with an API that is familiar with them - java.util.Map (opinion).
Will see how it evolves over time, planning to use it in some private code.
It can also serve as an example on how to implement some functionality on top of datalevin.
For example, I don't know yet how to implement clear, size, values methods on top of LMDB/datalevin.
Fixes #109