Back out message pre-rendering #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time extending the new message pre-rendering support from #228 to also cover dotted property names. Unfortunately, in the process, I discovered that this technique doesn't work with the Seq Events screen, and there's not an obvious path forward to get the experience people will want, there.
So, I've backed out message pre-rendering for now. But since our efforts to add it resulted in some API breakage, instead of backing those changes out entirely, I've switched
SeqCompactJsonFormatter.FormatEvent()from a static method to an instance one. This cleans up the inner workings ofSeqCompactJsonFormatterquite a bit and leaves us with more options to evolve that type in the future. The type itself is only a few months old, so unlikely to cause downstream breakage in unmaintained projects. Good time to jump in and course-correct :-)