This repository was archived by the owner on Aug 21, 2023. It is now read-only.
valgrind memory fixes #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed struct not an intialized on, with a warning it will leak if initialized.
…ng, however there are still issues.
…ng, however there are still issues.
…ng, however there are still issues.
…sure why , but caling append array, then append doc caused a segfault invalid memory location .Invalid memory access (signal 11) at address 0x0
several memory fixes have been applied due to valgrind findings and spec details reviewd
several memory fixes have been applied due to valgrind findings and spec details reviewd
…to be filled pointer
…itialized in the driver pointer .
…y for converting hash and arrays to bson objects,
I instead updated the appropiate items, so we will to_json(io) on the hash or array, then let the lib allocate and manage creation of the bson object, as append document needs an unitialized struct to prevent memory leaks, however in recursive looping down to serial a hash to bson or array to bson, intermeidate bson pointers are leaking after 2nd level depth i.e. {"$or" => [{ "field" =>{ "$lte" : 1 },{ "field" =>{ "$gte" : 3 }] } will leak. ne method doesnt leak at all, and benchmark looks ok
…pected. override tiem tojosn for bson format
|
Great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory fixes and crystal 0.30.1 update