Copy-DbaDatabase: Fix renaming for database names with special characters #10187
Merged
potatoqualitee merged 1 commit intodevelopmentfrom Feb 26, 2026
Merged
Copy-DbaDatabase: Fix renaming for database names with special characters #10187potatoqualitee merged 1 commit intodevelopmentfrom
potatoqualitee merged 1 commit intodevelopmentfrom
Conversation
…bNameInFile When Copy-DbaDatabase is used with -NewName, log files with suffixed names (e.g. Test2_log2.ldf) were not being renamed. The root cause is that $History.OriginalDatabase and $History.Database were accessed inside a ForEach-Object pipeline, which can introduce scoping issues. Additionally, the -Replace operator was treating the database name as a regex pattern rather than a literal string. The fix captures $originalDb and $newDb as local variables before the ForEach-Object loop and uses [regex]::Escape() to ensure database names containing regex special characters are treated as literal strings. A new integration test context is added to verify that both data and log files are renamed when using the string form of ReplaceDatabaseName with -ReplaceDbNameInFile. The test uses RestoreTimeClean.xml which has a log file with a _log suffix (RestoreTimeClean_log.ldf), matching the real-world scenario from the issue report. Fixes #10177 (do *Format*BackupInformation*) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
andreasjordan
changed the title
Member
|
Nice and concise 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #10177
Generated with Claude Code
Please see issue for details. I have tested this fix successfully with a database named
Test$test.