feat: Migrate from login to sso #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Realised I forgot to update the nomad configuration, will fix later! |
Contributor
|
Everything looks good! Your solution to the nginx problem is cleaner than the one I came up with. Just fix the job file and I'll run a last test and approve the PR |
Comment on lines
+68
to
+69
| location / { | ||
| proxy_pass http://nyckeln:7003; |
This required adding jumbojett/openid-connect-php as a dependency, as well as fixing the nginx configuration in the Docker Compose dev environment.
laxsjo
force-pushed
the
login-to-sso-migration
branch
from
141954f to
2d1557a
Compare
Contributor
Author
|
I force-pushed a version with my best guess for the nomad configuration now. Tell me if anything looks strange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required adding jumbojett/openid-connect-php as a dependency, as well as fixing the Nginx configuration in the Docker Compose dev environment.
I had to change how Nginx is configured in the dev compose file to make the nyckeln service available to the server. This is necessary as this project also uses Nginx for its web server, which the dev configuration needs to co-exist with. (If you have any thoughts for how I could have solved it more idiomatically I'm open to suggestions.)
Resolves #17