Skip to content

Conversation

@RafDevX
Copy link
Member

@RafDevX RafDevX commented Mar 7, 2025

LoL-ansvarig wants a way to tell if the people using META are using any special equipment, so he can know whether to approve separate bookings for e.g. microphones.

Ideally, Pandora would support some kind of "dual-booking" for multiple entities, wherein both META and LoL-equipment could be booked at the same time for the same reason (and be moved together when edited, etc.). However, that would require considerable effort to implement, disproportionate to the real benefit of this feature.

Instead, this PR adds a new question to opt-in entities, making it so the person reviewing LoL bookings only needs to check if simultaneous META bookings require something special and so clash. There's still the edge case of META being booked (with need for equipment) after a separate LoL-equipment booking has already been approved, but I don't think there's anything that can be easily done to fix this. (META bookings are shown on the LoL calendar, so it's easy to check them, but not the other way around, so Lokalchef can't easily see if someone already has LoL when reviewing META booking requests)

Note: I don't speak Swedish, someone else will have to fix the publicly-visible text to grammatically-correct sentences!

@RafDevX RafDevX added the feature label Mar 7, 2025
@RafDevX RafDevX self-assigned this Mar 7, 2025
Comment on lines +73 to +78
@if ($event->entity->lol_question)
<tr>
<td>Behövas speciell LoL-utrustning:</td>
<td> {{ $event->lol ? 'Ja' : 'Nej' }}</td>
</tr>
@endif
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently under Information som inte visas för alla since it was copied from Alcohol, but there might be marginal interest in making it publicly visible?

@RafDevX
Copy link
Member Author

RafDevX commented Mar 7, 2025

Note that this adds a boolean, yes/no question about whether any special equipment is needed, but it probably makes more sense to ask what equipment in specific they need, aka using a text field.

However, this might make the UI more awkward, since if they don't need any equipment they'd either leave it blank (and the system accept blanks) or write some variation of "No". I don't really want to add a radio guard (yes/no question followed by text question that is only shown for yes) either, because effort...

Would this be critical to meet LoL-ansvarig needs, or is the yes/no enough?

@abooddaker
Copy link

I really apologize for the extremely late reply, I wrote a reply few weeks ago but I apparently didn't send it, totally my bad.

A yes / no question won't really solve the issue for the people who click yes. I will still have to contact them manually and check what equipment exactly they want to use. But if they answer no then that helps me of course. But the problem still stands when someone answers with yes. So up to you guys, you decide what easiest. I would prefer a text box where the person booking META writes down "I want to use the wireless mics and speakers" for example. Or we could just have a text box without a yes or no question, but instead the person booking could fill it with anything "nothing" could be an example. But again, up to you guys. Thanks so much for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants