Add LoL-utrustning question #52
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoL-ansvarig wants a way to tell if the people using META are using any special equipment, so he can know whether to approve separate bookings for e.g. microphones.
Ideally, Pandora would support some kind of "dual-booking" for multiple entities, wherein both META and LoL-equipment could be booked at the same time for the same reason (and be moved together when edited, etc.). However, that would require considerable effort to implement, disproportionate to the real benefit of this feature.
Instead, this PR adds a new question to opt-in entities, making it so the person reviewing LoL bookings only needs to check if simultaneous META bookings require something special and so clash. There's still the edge case of META being booked (with need for equipment) after a separate LoL-equipment booking has already been approved, but I don't think there's anything that can be easily done to fix this. (META bookings are shown on the LoL calendar, so it's easy to check them, but not the other way around, so Lokalchef can't easily see if someone already has LoL when reviewing META booking requests)
Note: I don't speak Swedish, someone else will have to fix the publicly-visible text to grammatically-correct sentences!