Skip to content

Short-lived & unique SCB for each run #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

pravinbhat
Copy link
Collaborator

@pravinbhat pravinbhat commented Oct 11, 2024

What this PR does: Makes SCB file much short-lived & unique to each run

Which issue(s) this PR fixes:
Fixes #316

Checklist:

  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@pravinbhat pravinbhat requested a review from a team as a code owner October 11, 2024 15:20
@pravinbhat pravinbhat linked an issue Oct 11, 2024 that may be closed by this pull request
Copy link
Collaborator

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@@ -31,7 +31,8 @@
import com.datastax.cdm.schema.CqlTable;

public class DataUtility {
public static final Logger logger = LoggerFactory.getLogger(CqlConversion.class);
public static final Logger logger = LoggerFactory.getLogger(DataUtility.class.getName());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@msmygit msmygit enabled auto-merge (squash) October 11, 2024 15:34
@pravinbhat pravinbhat disabled auto-merge October 11, 2024 21:03
@pravinbhat pravinbhat merged commit cd54ca7 into main Oct 11, 2024
9 checks passed
@pravinbhat pravinbhat deleted the feature/short-lived-scb branch October 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Secure Bundle as a Stream of Objects
2 participants