WIP - do not review or commit! Fix RequestFailureReason reason codes according to Apache and avoid f… #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ReplicaPlan to replace AbstractReplicaPlan.blockFor with AbstractForRead.readQuorum in alignment with Apache 5.0.
…ories to first be called, as does GuardrailsOptions.validateDataDiskUsageMaxDiskSize. Update SnapshotLoader to store File instead of Path.
Fixes log check in python dtest materialized_views_test.test_drop_with_stopped_build.
Note that most of this commit is already in apache/cassandra-5.0, but it was added after we started the rebase. It is adjusted for CC
…esDuration and expandUserTypes
…and freezeNestedMultiCellTypes as they were unused
Auto-freeze nested types of frozen types with a log message
…thods The AbstractType.toString() is now final and it calls toString(ignoreFreezing=false). OTOH toString(ignoreFreezing) is the method the other classes should override (which is applied in this commit). This makes more sense as toString() is now consistent. For VectorType - inlined TypeParser.stringifyVectorParameters because vector type parameter is always a primitive (actually it can only be a number type) so ignore freezing flag makes no sense
Common validations were moved to AbstractType.validateForColumn and therefore we could remove the repeated code from few places
Loosen validation of a newly created UDT - we just check that it does not contain counter columns. Add some validation when reading columns from SchemaKeyspace. Perform more keyspace validations when a keyspace is created or altered.
…x NPE in CNDB mocked tests; Part of STAR-1314 Use more CFS getters for CNDB mocked test
* Allow SortedLocalRanges to be empty * Fix SortedLocalRanges.testNoRanges
#1392) correctly decode TTLs after 2037 in SortedStringTableCursor
Split all the tests extending AbstractQueryTester so they are less prone to timeouts and better for CI parallelization. Each test class is split into a class per data model, and each class is still parameterized by index version. Also, move these tests and their utilities into their own package, and rename the two versions of AbstractQueryTester to SingleNodeQueryTester and MultiNodeQueryTester.
…1395) Increase the timeout for waiting on the index creation. We are indexing more vectors than usual, so the default one-minute timeout might not be enough.
#1397) The rejection of terms depends on CassandraRelevantProperties.VALIDATE_MAX_TERM_SIZE_AT_COORDINATOR. The test should check both the enabled and disabled scenarios.
Use UCS with a single shard, increase index build timeout and improve assertions
…est (#1413) `CQLUnifiedCompactionTest.testMultipleCompactionsDifferentWs` needs max_sstables_to_compact increased to pass.
…ain-5.0 (#1412) It is not natural to have SAI iterator classes in `utils` package, furthermore, Apache Cassandra has them in a separate package `iterators`. Also ASF C* has consistent naming for iterator classes. Similar to SAI listing classes. Closes riptano/cndb#11563 This PR does similar changes as #1400: - Moves SAI iterator classes from `utils` package to new package `iterators` - Renames SAI iterator classes to be consistent and equivalent to ASF C* for the same classes. - Removes `AbstractIterator` replaces its usages with `AbstractGuavaIterator` from the general `utils` package. This is in accordance with ASF C*. - Renames and moves SAI postings classes from `utils` package to new package `postings`, which is in accordance with ASF C*. This will help with rebasing CC on ASF C* 5.0.
…SANDRA-13043 (#1406) Restores the filter from CASSANDRA-13043 for nodes that are rpc_ready
…actType.overrideKeyspace is called in CNDB.
… migrate/deserialize Astra/CC 4.0 schemas.
… created but otherwise not used; STAR-1353 changes allow realm to be null and in that case VerifyController creation fails because AbstractCompactionController requires realm to be non-null. Add @nullable annotation to realm instance variable to highlight the value may be null.
HCD-18 add option to ignore DC name validation
Added a new system property "cassandra.dc_skip_name_validation",
which is used to bypass "ConfigurationException: Unrecognized strategy
option {group20} passed to NetworkTopologyStrategy" messages when
creating/altering replication strategy to a DC that doesn't exist
In cassandra versions <4 and DSE 5.1 there was less strict validation
when adding a datacenter. The nodes could be added first, or the
keyspace replication schema could be changed to include the new DC
first.
With CASSANDRA-12681, validation was added to check that a DC exists
before letting it be used in the replication strategy.
We have customers (Netapp) that have existing automation tooling for
adding datacenters that require this additional validation to be
optionally disabled.
…uture conflicts by assigning new codes to higher numbers
ekaterinadimitrova2
force-pushed
the
CNDB-7343-main-5.0
branch
from
2844f34 to
822239e
Compare
ekaterinadimitrova2
force-pushed
the
CNDB-7343-main-5.0
branch
from
c239e3f to
822239e
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
❌ Build ds-cassandra-pr-gate/PR-1457 rejected by Butler1 new test failure(s) in 3 builds Found 1 new test failures
No known test failures found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uture conflicts
by assigning new codes to higher numbers
What is the issue
...
What does this PR fix and why was it fixed
...
Checklist before you submit for review
NoSpamLoggerfor log lines that may appear frequently in the logs