Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12308: Remove index-based sorting at CQL level #1488

Merged
merged 2 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,6 @@ public final boolean hasSupportingIndex(IndexRegistry indexRegistry)
return false;
}

@Override
public final Index findSupportingIndex(IndexRegistry indexRegistry)
{
for (Index index : indexRegistry.listIndexes())
if (isSupportingIndex(index))
return index;
return null;
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,6 @@ public default boolean isOnToken()
*/
public boolean hasSupportingIndex(IndexRegistry indexRegistry);

/**
* Find first supporting index for current restriction
*
* @param indexRegistry the index registry
* @return <code>index</code> if the restriction is on indexed columns, <code>null</code>
*/
public Index findSupportingIndex(IndexRegistry indexRegistry);

/**
* Returns whether this restriction would need filtering if the specified index group were used.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return false;
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
return null;
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down Expand Up @@ -283,18 +277,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return false;
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
for (SingleRestriction restriction : restrictionsMap.values())
{
Index index = restriction.findSupportingIndex(indexRegistry);
if (index != null)
return index;
}
return null;
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return restrictions.hasSupportingIndex(indexRegistry);
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
return restrictions.findSupportingIndex(indexRegistry);
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return false;
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
for (Index index : indexRegistry.listIndexes())
if (isSupportedBy(index))
return index;

return null;
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return restrictions.hasSupportingIndex(indexRegistry);
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
return restrictions.findSupportingIndex(indexRegistry);
}

@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,6 @@ public boolean hasSupportingIndex(IndexRegistry indexRegistry)
return false;
}

@Override
public Index findSupportingIndex(IndexRegistry indexRegistry)
{
return null;
}
@Override
public boolean needsFiltering(Index.Group indexGroup)
{
Expand Down
Loading