CNDB-12075: Allow UDFs within GROUP BY clause

[adelapena]

Port of DB-672.

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1494 rejected by Butler

---

58 new test failure(s) in 2 builds
See build details here

---

Found 58 new test failures

Showing only first 15 new test failures

Test	Explanation	Branch history	Upstream history
t.TestCqlshUnicode.test_unicode_identifier	regression	🔴🔴
o.a.c.d.c.CompactionControllerTest.testMemtable...	regression	🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40	regression	🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50	regression	🔴🔴
...ersionTest.v4ConnectionCleansUpThreadLocalState	regression	🔴🔴
...d.t.QueriesTableTest.shouldExposeReadsAndWrites	regression	🔴🔴
...rtitionRestrictedQueryTest.testSAIWarnThreshold	regression	🔴🔴
...eadSizeWarningTest.warnThresholdSinglePartition	regression	🔴🔴
o.a.c.i.c.CompressionMetadataTest.testMemoryIsF...	regression	🔴🔴
...ientRequestMetricsLatenciesTest.testReadMetrics	regression	🔴🔴
...entRequestMetricsLatenciesTest.testWriteMetrics	regression	🔴🔴
...ntIrWithPreviewFuzzTest.concurrentIrWithPreview	regression	🔴🔴
o.a.c.t.SSTablePartitionsTest.testBackups	regression	🔴🔴
o.a.c.t.SSTablePartitionsTest.testCurrentTimestamp	regression	🔴🔴
o.a.c.t.SSTablePartitionsTest.testExcludedKeys	regression	🔴🔴

---

Found 3 known test failures

[szymon-miezal]

This change looks good to me.
The patch ports the important functional bits from DB-672 and makes sure these are tested thoroughly. I see no reason to not approve it - remember though that I am quite untrained when it comes to judging the CC CI test results.
I have only left a minor comment related to an assertion in a test. It refers more to the tooling usage aspect than any serious functional impact, you might as well ignore it.

[djatnieks]

fwiw, this is a comparison between this branch and CNDB-12154 - looks good to me :)

http://butler-stargazer.aws.dsinternal.org/#/ci/upstream/compare/ds-cassandra-pr-gate/CNDB-12075-CNDB-12154/to/ds-cassandra-pr-gate/CNDB-12154

[djatnieks]

@adelapena Is it okay with you if I merge this to CNDB-12154 today?

[adelapena]

Sure, let's merge!