Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of SingleRestrictionEstimatedRowCountTest #1502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

k-rus
Copy link

@k-rus k-rus commented Jan 14, 2025

Reduces amount of created tables by creating all needed tables in advance. As the result the test can be placed into single test function.
This improves local test execution time from 5.5 seconds down to 1.4 seconds.

Also removes disabling optimizer, which wasn't necessary.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@k-rus k-rus force-pushed the rf-row-count-test-faster branch from cb4f9c5 to a0fe1cb Compare January 14, 2025 20:32
k-rus added 3 commits January 14, 2025 22:04
There is no need to disable the optimizer, since it cannot optimize
away anything. It was necessary originally during introducing anti-join
node.
Fails due to flush when next table is created, and on cleanup after a
test run.
Reduces amount of created tables by creating all needed tables in
advance. As the result the test can be placed into single test
function.

This improves local test execution time from 5.5 seconds down to 1.4
seconds.
@k-rus k-rus force-pushed the rf-row-count-test-faster branch from a0fe1cb to 0b231f9 Compare January 14, 2025 21:05
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1502 rejected by Butler


3 new test failure(s) in 2 builds
See build details here


Found 3 new test failures

Test Explanation Branch history Upstream history
...oParseClientMessageTest.badHeader[version=5/v5] regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵
...,dataset=inet,wide=true,scenario=SSTABLE_QUERY] regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵
...t,varint>,wide=false,scenario=POST_BUILD_QUERY] regression 🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 8 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants