Skip to content

Conversation

@djatnieks
Copy link

What is the issue

CNDB-11460 - several cqlsh (jvm dtest) tests in TestCqlshUnicode consistently fail, with an error like:

E           UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 4-5: unexpected end of data

What does this PR fix and why was it fixed

I took a look at the test code and asked Augment for suggestions - it recommended adding some code to handle UTF-8 characters that may be split across reads. I tried the code and it looks like it does the job.

@github-actions
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1561 rejected by Butler


1 new test failure(s) in 2 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔴 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

@driftx driftx self-requested a review February 21, 2025 12:26
@djatnieks djatnieks merged commit 46ec671 into main Feb 21, 2025
466 of 476 checks passed
@djatnieks djatnieks deleted the CNDB-11460-test-cqlsh-unicode branch February 21, 2025 14:05
djatnieks added a commit that referenced this pull request Mar 11, 2025
djatnieks added a commit that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants