CNDB-14301: couple jvector file format and SAI version #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
|
Companion CNDB test PR: https://github.com/riptano/cndb/pull/14303 |
eolivelli
requested changes
Jun 5, 2025
| @Override | ||
| public int jvectorFileFormatVersion() | ||
| { | ||
| // Before version EB, we used JVector format 2. Version DC introduced format 4, so we can start using it |
There was a problem hiding this comment.
according to my testing here https://github.com/riptano/cndb/issues/14247#issuecomment-2943230825 JVector 4.0.0.beta1 shipped with the March release does not support format 4 and at that time the default version was DC
we can map format 4 only to ED or later
There was a problem hiding this comment.
Thank you for catching this! You're right, my change is off-by-one
There was a problem hiding this comment.
This is fixed now, please take a look.
|
❌ Build ds-cassandra-pr-gate/PR-1786 rejected by Butler1 new test failure(s) in 3 builds Found 1 new test failures
Found 7 known test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes: https://github.com/riptano/cndb/issues/14301
What does this PR fix and why was it fixed
Make version
ECand later use jvector file format 4. Also allow for some configurability in earlier versions just in case we have some clusters relying on that behavior via thecassandra.sai.jvector_versionsystem property (defaults to 2 and is ignored forECand later).