Skip to content

CNDB-14614-re-merge: abort compaction task or index build if index is unloaded after tenant unassignment (#1766) #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

driftx
Copy link

@driftx driftx commented Jun 20, 2025

When schema is unloaded after tenant unassignment, compaction task might finishes without corresponding index files, making index non-queryable.

Replace isValid with isDropped and isUnloaded. If index is dropped, compaction task or index build can proceed without the index, same behavior as before. If index is unloaded, compaction task or index build will be aborted to avoid completing without index files.


#1754 was reverted because CNDB PR compiled failed with wrong hash. Re-merge it again.

… unloaded after tenant unassignment (#1766)

When schema is unloaded after tenant unassignment, compaction task might
finishes without corresponding index files, making index non-queryable.

Replace `isValid` with `isDropped` and `isUnloaded`. If index is
dropped, compaction task or index build can proceed without the index,
same behavior as before. If index is unloaded, compaction task or index
build will be aborted to avoid completing without index files.

---

#1754 was reverted because[
CNDB PR](riptano/cndb#14179) compiled failed
with wrong hash. Re-merge it again.
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Jun 20, 2025

nowInSec from int to long

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1828 rejected by Butler


12 new test failure(s) in 1 builds
See build details here


Found 12 new test failures

Test Explanation Branch history Upstream history
....r.PendingAntiCompactionTest.testRetriesTimeout regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴
o.a.c.d.t.r.ForceRepairTest.forceWithDifference regression 🔴
...estIndexRebuildWhenAddingSStableViaRemoteReload regression 🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴
...m.TrieMemtableMetricsTest.testContentionMetrics regression 🔴
o.a.c.n.NodesPersistenceTest.testUpdateTokens regression 🔴
o.a.c.t.SSTablePartitionsTest.testDirectory regression 🔴
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴

No known test failures found

@driftx driftx merged commit 6c53963 into main-5.0 Jul 1, 2025
574 of 589 checks passed
@driftx driftx deleted the CNDB-14534 branch July 1, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants