CNDB-141284: use ByteBuffer.remaining instead of limit to asset size (#1755)

[driftx]

The data inserted into the trie in TrieMemoryIndex is encodedTerm, which is built from term and only on the "available" bytes (between term.position() and term.limit()). But the check that decides to use the (more efficient) recursive path or not uses term.limit() to assess the size of encodedTerm. If term.position() is not 0, this is incorrect, and can lead to using the less optimal pass completely unecessarily. This has been shown to happen when investigating https://github.com/riptano/cndb/issues/14153: the non-recursive path was taken even for boolean values (because the nodes were using offheap_buffers; with offheap_objects, the buffers getting to TriMemoryIndex are 0-positioned).

See https://github.com/riptano/cndb/issues/14184.

[driftx]

Clean merge

[github-actions]

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits
• All new files should contain the DataStax copyright header instead of the Apache License one

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1829 rejected by Butler

---

11 new test failure(s) in 1 builds
See build details here

---

Found 11 new test failures

Test	Explanation	Branch history	Upstream history
...estInterruptedExceptionCachedCounterLockManager	regression	🔴
....r.PendingAntiCompactionTest.testRetriesTimeout	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50	regression	🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE	regression	🔴
...thRestartTest.testReadingValuesOfDroppedColumns	regression	🔴
o.a.c.d.t.r.ForceRepairTest.force	regression	🔴
...estIndexRebuildWhenAddingSStableViaRemoteReload	regression	🔴
o.a.c.i.s.d.OnDiskIndexTest.testSparseMode	regression	🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables	regression	🔴
o.a.c.t.SSTablePartitionsTest.testDirectory	regression	🔴

---

No known test failures found