CNDB-14586: Fix StorageHandlerTest#testOnOpeningWrittenSSTableFailure on bigtable #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on bigtable by retargeting byteman rule at shared trie/bigtable method
Checklist before you submit for review
|
|
Note: in fastci, we don't run bigtable tests. I've run this locally for bigtable, compression, and regular unit test targets. |
|
❌ Build ds-cassandra-pr-gate/PR-1833 rejected by Butler1 new test failure(s) in 1 builds Found 1 new test failures
Found 1 known test failures |
jtgrabowski
approved these changes
Jun 26, 2025
driftx
pushed a commit
that referenced
this pull request
Jul 21, 2025
… on bigtable (#1833) ### What is the issue This test injects a failure on opening written sstables using byteman. The injection point is only called for trie-index sstables, so the test fails on bigtable, as the expected error isn't thrown. ### What does this PR fix and why was it fixed This PR retargets the failure injection to a shared method in the hierarchy of trie-index and bigtable sstables. This ensures we see the expected failure for both sstable families.
driftx
pushed a commit
that referenced
this pull request
Jul 21, 2025
… on bigtable (#1833) ### What is the issue This test injects a failure on opening written sstables using byteman. The injection point is only called for trie-index sstables, so the test fails on bigtable, as the expected error isn't thrown. ### What does this PR fix and why was it fixed This PR retargets the failure injection to a shared method in the hierarchy of trie-index and bigtable sstables. This ensures we see the expected failure for both sstable families.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
This test injects a failure on opening written sstables using byteman. The injection point is only called for trie-index sstables, so the test fails on bigtable, as the expected error isn't thrown.
What does this PR fix and why was it fixed
This PR retargets the failure injection to a shared method in the hierarchy of trie-index and bigtable sstables. This ensures we see the expected failure for both sstable families.