Skip to content

CNDB-14554: Fix 2 PEP8 violations in cql - E127 and W293; This fixes Python DTest test_pycodestyle_compliance #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

ekaterinadimitrova2
Copy link

…Python DTest test_pycodestyle_compliance

What is the issue

...
test_pycodestyle_compliance failing

What does this PR fix and why was it fixed

...
Fix 2 PEP8 violations in cql - E127 and W293; This fixes Python DTest test_pycodestyle_compliance

Copy link

github-actions bot commented Jun 29, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@ekaterinadimitrova2 ekaterinadimitrova2 requested review from a team and removed request for a team June 29, 2025 18:14
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1837 rejected by Butler


2 new test failure(s) in 1 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
o.a.c.i.s.c.VectorCompactionTest.testPQRefine[dc] regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

No known test failures found

@ekaterinadimitrova2
Copy link
Author

VectorCompactionTest.testPQRefine is the only new failure, but it seems like an unrelated flaky. I just opened a separate ticket for it.

@ekaterinadimitrova2 ekaterinadimitrova2 removed the request for review from a team June 30, 2025 19:54
@ekaterinadimitrova2
Copy link
Author

Thank you for the review.
I wanted to commit, but then I saw that SonarCloud was still in the expected state. Something got stuck, I guess? Merge is blocked on it. I will investigate.

@ekaterinadimitrova2 ekaterinadimitrova2 marked this pull request as draft July 1, 2025 15:40
@ekaterinadimitrova2 ekaterinadimitrova2 marked this pull request as ready for review July 1, 2025 15:40
@ekaterinadimitrova2
Copy link
Author

Pushed empty commit to trigger CI again

Copy link

sonarqubecloud bot commented Jul 1, 2025

@ekaterinadimitrova2
Copy link
Author

ekaterinadimitrova2 commented Jul 1, 2025

All jobs but Butler finished successfully. (Butler fails on all PRs today, nothing related to what we do here)
https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/job/PR-1837/4/cloudbees-pipeline-explorer/?filter=41543
All tests pass:
https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/job/PR-1837/4/
Quality gate also passed. Merging

@ekaterinadimitrova2 ekaterinadimitrova2 merged commit 934e2b0 into main Jul 1, 2025
492 of 495 checks passed
@ekaterinadimitrova2 ekaterinadimitrova2 deleted the CNDB-14554 branch July 1, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants