Skip to content

CNDB-14798: Upgrade to jvector 4.0.0-rc1 #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

michaeljmarshall
Copy link
Member

(cherry picked from commit 16efd4c)

What is the issue

Fixes: https://github.com/riptano/cndb/issues/14798

What does this PR fix and why was it fixed

Upgrade jvector from 4.0.0-beta.5 to 4.0.0-rc1.

Here is the list of commits included in the upgrade: datastax/jvector@4.0.0-beta.5...4.0.0-rc.1

Here is a copy of the relevant CHANGELOG.md lines:

4.0.0-rc.1

  • Fix issue when calling cleanup while concurrently executing searches #483
  • Improve the efficiency and memory usage of GraphIndexBuilder.cleanup #477
  • add PQ training benchmark #482
  • Remove extraneous character from datasets.yml #484
  • Upgrade YAML files to v5 after the format was introduced in the last update #478
  • New chunked memory-mapped reader that supports >2GB files 61bffbe
  • release 4.0.0-rc.1 6737596
  • Fix comparison in TestADCGraphIndex b637f65

4.0.0-beta.6

13 June 2025

@michaeljmarshall michaeljmarshall self-assigned this Jul 14, 2025
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1868 rejected by Butler


1 new test failure(s) in 1 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.s.SensorsReadTest.BeforeFirstTest regression 🔴

No known test failures found

Copy link

@tlwillke tlwillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to ensure the test failures are unrelated and/or flaky.

Copy link

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljmarshall
Copy link
Member Author

michaeljmarshall commented Jul 15, 2025

The failure for org.apache.cassandra.sensors.SensorsReadTest.BeforeFirstTest was a timeout and it failed on a recent main run, so it doesn't look like a regression introduced by this PR. Further, this PR doesn't touch anything related to that test, making it even less likely to be a regression.

@michaeljmarshall michaeljmarshall merged commit f8101c7 into cndb-main-release-202508 Jul 15, 2025
488 of 493 checks passed
@michaeljmarshall michaeljmarshall deleted the cndb-14798 branch July 15, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants