Skip to content

CNDB-14144: Change Version.LATEST to ED. Move testIndexMetaForNumRowsfrom BM25Test to FeaturesVersionSupportTest and extend coverage for all versions. Add FeaturesVersionSupportEDTest. Make BM25Test tests run on all sai versions post BM25_EARLIEST #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

driftx
Copy link

@driftx driftx commented Jul 14, 2025

No description provided.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Jul 14, 2025

No changes.

@driftx driftx requested a review from djatnieks July 14, 2025 20:11
Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was a build failure

… from BM25Test to FeaturesVersionSupportTest and extend coverage for all versions. Add FeaturesVersionSupportEDTest. Make BM25Test tests run on all sai versions post BM25_EARLIEST
@driftx
Copy link
Author

driftx commented Jul 16, 2025

This needed previous commits that are now present, and I had to make it skip the ED test when the latest version is ED.

@driftx driftx requested a review from djatnieks July 16, 2025 15:07
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1869 rejected by Butler


33 new test failure(s) in 1 builds
See build details here


Found 33 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
...lidation.operations.AlterTest-compression_jdk11 regression 🔴
...nQueryShouldNotTimeoutWhenItExceedesReadTimeout regression 🔴
...nglePageReadIsFastButAggregationExceedesTimeout regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDBTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDCTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportEBTest.testANN regression 🔴
...c.FeaturesVersionSupportTest.testANNSupport[eb] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[aa] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[ba] regression 🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴
o.a.c.t.SSTablePartitionsTest.testDirectory regression 🔴

No known test failures found

@driftx driftx merged commit c618384 into main-5.0 Jul 17, 2025
567 of 586 checks passed
@driftx driftx deleted the CNDB-14795 branch July 17, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants