CNDB-14683: Cherry-pick fix for flaky LogTransactionTest #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Failure: org.apache.cassandra.db.lifecycle.LogTransactionTest.testGetTemporaryFilesSafeAfterObsoletion-cdc patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17286
Checklist before you submit for review
|
|
✔️ Build ds-cassandra-pr-gate/PR-1870 approved by ButlerApproved by Butler |
djatnieks
approved these changes
Jul 15, 2025
driftx
pushed a commit
that referenced
this pull request
Jul 24, 2025
### What is the issue This test is flaky. It stresses the log transaction framework by intentionally creating a race between transaction file cleanup and the listing of temporary files. It sometimes throws an exception during canonicalization of a file that has been removed, but this canonicalization is being done by the testing code, not the transaction code, and it does not indicate misbehavior by the log transaction. ### What does this PR fix and why was it fixed Cherry-picks the fix for this in newer apache/cassandra releases. This ignores exceptions due to files not being found during canonicalization. original patch authored by Jon Meredith, reviewed by Josh McKenzie for CASSANDRA-17286
driftx
pushed a commit
that referenced
this pull request
Jul 25, 2025
### What is the issue This test is flaky. It stresses the log transaction framework by intentionally creating a race between transaction file cleanup and the listing of temporary files. It sometimes throws an exception during canonicalization of a file that has been removed, but this canonicalization is being done by the testing code, not the transaction code, and it does not indicate misbehavior by the log transaction. ### What does this PR fix and why was it fixed Cherry-picks the fix for this in newer apache/cassandra releases. This ignores exceptions due to files not being found during canonicalization. original patch authored by Jon Meredith, reviewed by Josh McKenzie for CASSANDRA-17286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
This test is flaky. It stresses the log transaction framework by intentionally creating a race between transaction file cleanup and the listing of temporary files. It sometimes throws an exception during canonicalization of a file that has been removed, but this canonicalization is being done by the testing code, not the transaction code, and it does not indicate misbehavior by the log transaction.
What does this PR fix and why was it fixed
Cherry-picks the fix for this in newer apache/cassandra releases. This ignores exceptions due to files not being found during canonicalization.