Merged
Conversation
Checklist before you submit for review
|
djatnieks
approved these changes
Jul 15, 2025
…1789) - **CNDB-14317: Optimize doc freq computation for memtable BM25 queries** - **Update approximateTotalTermCount() javadoc** ### What is the issue Fixes riptano/cndb#14317 ### What does this PR fix and why was it fixed We optimize the in memory BM25 computation by using the trie to get the number of rows matching a query term. This change removes a memtable scan and analyze by replacing it with calls to the index to get the number of docs. There are no new tests because it is expected to maintain the same semantics. I will review the test coverage to verify that assertion.
|
❌ Build ds-cassandra-pr-gate/PR-1876 rejected by Butler35 new test failure(s) in 2 builds Found 35 new test failuresShowing only first 15 new test failures
Found 2 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This ports CNDB-14317 to main-5.0, but it is based off of CNDB-14791 which is needed.