CNDB-14361 use node's total document and term counts (#1791) #1877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
BM25 score needs to use document average length aggregated on entire node.
Also a bug was discovered, which was introduced by #1789: term frequencies don't
include documents filtered by other predicates, which makes inconsistent result
between query plans.
What does this PR fix and why was it fixed
Fixes https://github.com/riptano/cndb/issues/14361
Changes that BM25 score uses document count and term count aggregated on entire node instead of per segment. Fixes a bug in calculating term frequencies, so
they count all documents.
As the work added more code duplication all duplicated code is refactored in getTopKRows methods.
In addition removes unnecessary public modifier in afffected interface.