Skip to content

CNDB-14348: Forbid BM25 queries on non-regular columns (#1793) #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

driftx
Copy link

@driftx driftx commented Jul 16, 2025

BM25 queries don't work on indexes on non-regular columns.

Until we have a way to support them, this PR simply forbids BM25 queries on non-regular columns.

The creation of analyzed indexes in those columns is still allowed because they can be successfully queried with regular expression filters using equality and match operators.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Jul 16, 2025

Adjusted imports.

Copy link

@driftx driftx requested a review from djatnieks July 16, 2025 20:16
BM25 queries don't work on indexes on non-regular columns.

Until we have a way to support them, this PR simply forbids BM25 queries
on non-regular columns.

The creation of analyzed indexes in those columns is still allowed
because they can be successfully queried with regular expression filters
using equality and match operators.
@driftx driftx merged commit 9334018 into main-5.0 Jul 17, 2025
6 of 513 checks passed
@driftx driftx deleted the CNDB-14813 branch July 17, 2025 14:20
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1878 rejected by Butler


33 new test failure(s) in 2 builds
See build details here


Found 33 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
...lidation.operations.AlterTest-compression_jdk11 regression 🔴🔴
...nQueryShouldNotTimeoutWhenItExceedesReadTimeout regression 🔴🔴
...nglePageReadIsFastButAggregationExceedesTimeout regression 🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 regression 🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDBTest.testANN regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDCTest.testANN regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportEBTest.testANN regression 🔴🔴
...c.FeaturesVersionSupportTest.testANNSupport[eb] regression 🔴🔴
....FeaturesVersionSupportTest.testGeoDistance[aa] regression 🔴🔴
....FeaturesVersionSupportTest.testGeoDistance[ba] regression 🔴🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴🔴
...m.TrieMemtableMetricsTest.testContentionMetrics regression 🔴🔵

Found 1 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants