CNDB-14239: expose index components validation method with no side-effect (#1794) #1882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
IndexComponents#validateComponents
method validates some group of index components files (ensure we have all the files we should have, and ensure they looks valid), but it also has some side-effect backed in. It potentially deletes invalid components it found, and invalidate the whole group if validation fails, which rewrite the sstable TOC and whatnot.For CNDB, it would be useful to be able to validate components on reload without necessarily triggering the side effects, and the plan is to rely on such no-side-effect variant in the patch for
https://github.com/riptano/cndb/issues/14239. But I'd argue having this variant make sense in general and could easily have other uses later, and the changes are trivially backward compatible (they only introduce 2 new methods.