Skip to content

CNDB-11666: Batch clusterings into single SAI partition post-filterin… #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

michaeljmarshall
Copy link
Member

…g reads

(cherry picked from commit ae4f187)

What is the issue

...

What does this PR fix and why was it fixed

...

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@eolivelli
Copy link

I have confirmed that this patch solves the issue, we will try this docker image with Shadow Proxy

…g reads

Port of CASSANDRA-19497.

Co-authored-by: Caleb Rackliffe <[email protected]>
Co-authored-by: Michael Marshall <[email protected]>
Co-authored-by: Andrés de la Peña <[email protected]>
@adelapena adelapena force-pushed the cndb-11666-may-release branch from f61de5b to 5e29022 Compare July 21, 2025 12:00
@adelapena adelapena marked this pull request as ready for review July 21, 2025 12:00
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code is the same as #1883 (+ Version#after)

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1884 rejected by Butler


2 new test failure(s) in 1 builds
See build details here


Found 2 new test failures

Test Explanation Branch history Upstream history
....r.PendingAntiCompactionTest.testRetriesTimeout regression 🔴
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴

No known test failures found

@adelapena adelapena merged commit 6db0e9b into cndb-main-release-202505 Jul 23, 2025
483 of 489 checks passed
@adelapena adelapena deleted the cndb-11666-may-release branch July 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants