-
Notifications
You must be signed in to change notification settings - Fork 21
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and improve memory track to include array memory usage #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
…ach threshold of 300M to avoid overflow in Int2IntHashMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it would be better to enable the unit test, maybe by overriding the value of MAX_DOC_LENGTHS to a smaller value ? (we can override final static fields in unit tests, we should have the tools to do it)
ae8b248
to
c526937
Compare
|
✔️ Build ds-cassandra-pr-gate/PR-1885 approved by ButlerApproved by Butler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
…rove memory track to include array memory usage (#1885) ### What is the issue #14773: Int2IntHashMap overflow when num of docs reaches 348_966_081 ### What does this PR fix and why was it fixed Trigger segment flush before overflow and include array memory usage to avoid undercounting memory usage
…rove memory track to include array memory usage (#1885) ### What is the issue #14773: Int2IntHashMap overflow when num of docs reaches 348_966_081 ### What does this PR fix and why was it fixed Trigger segment flush before overflow and include array memory usage to avoid undercounting memory usage
What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081
What does this PR fix and why was it fixed
Trigger segment flush before overflow and include array memory usage to avoid undercounting memory usage