Skip to content

CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and improve memory track to include array memory usage#1885

Merged
jasonstack merged 3 commits intomainfrom
cndb-14773-main
Jul 22, 2025
Merged

CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and improve memory track to include array memory usage#1885
jasonstack merged 3 commits intomainfrom
cndb-14773-main

Conversation

@jasonstack
Copy link

@jasonstack jasonstack commented Jul 17, 2025

What is the issue

#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to avoid undercounting memory usage

@github-actions
Copy link

github-actions bot commented Jul 17, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

eolivelli
eolivelli approved these changes Jul 17, 2025
View reviewed changes
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

it would be better to enable the unit test, maybe by overriding the value of MAX_DOC_LENGTHS to a smaller value ? (we can override final static fields in unit tests, we should have the tools to do it)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

cassci-bot commented Jul 17, 2025

✔️ Build ds-cassandra-pr-gate/PR-1885 approved by Butler

Approved by Butler
See build details here

eolivelli
eolivelli approved these changes Jul 22, 2025
View reviewed changes
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jasonstack jasonstack merged commit 448841b into main Jul 22, 2025
492 checks passed
@jasonstack jasonstack deleted the cndb-14773-main branch July 22, 2025 06:20
driftx pushed a commit that referenced this pull request Jul 24, 2025
@jasonstack
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
6a9c838 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage
@driftx driftx mentioned this pull request Jul 24, 2025
Merged
driftx pushed a commit that referenced this pull request Jul 25, 2025
@jasonstack @driftx
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
b38dadc 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage
michaelsembwever pushed a commit that referenced this pull request Feb 6, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
ed617c1 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage
michaelsembwever pushed a commit that referenced this pull request Feb 10, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
9f74bbb 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Feb 11, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
d5f0527 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Feb 12, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
ed62f66 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Feb 14, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
f3c2078 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Feb 16, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
4ac09df 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Feb 27, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
f39fd89 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Mar 2, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
44058a8 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Mar 4, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
51e3674 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
michaelsembwever pushed a commit that referenced this pull request Mar 5, 2026
@jasonstack @michaelsembwever
CNDB-14773: avoid Int2IntHashMap overflow in RAMStringIndexer and imp…
68a96eb 
…rove memory track to include array memory usage (#1885)

### What is the issue
#14773: Int2IntHashMap overflow when num of docs reaches 348_966_081

### What does this PR fix and why was it fixed

Trigger segment flush before overflow and include array memory usage to
avoid undercounting memory usage

 (Rebase of commit b38dadc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkolaczk pkolaczk Awaiting requested review from pkolaczk

@michaeljmarshall michaeljmarshall Awaiting requested review from michaeljmarshall

1 more reviewer

@eolivelli eolivelli eolivelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonstack @cassci-bot @eolivelli