CNDB-14392: Use QueryView's MemtableIndex references for search (#1799) #1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes: https://github.com/riptano/cndb/issues/14392
What does this PR fix and why was it fixed
We incorrectly use the
liveMemtables
at search time instead of theQueryView.memtables
for the memory index search. This leads to incorrect behavior when a memtable is flushed or dropped after we acquire theQueryView
and before we search theliveMemtables
. The solution is easy: use the referencedQueryView
to get the memtables