Skip to content

CNDB-14477: Validate SAI Components (#1816) #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

CNDB-14477: Validate SAI Components (#1816) #1889

merged 1 commit into from
Jul 18, 2025

Conversation

driftx
Copy link

@driftx driftx commented Jul 17, 2025

  • CNDB-14477: Validate SAI Components
  • Add follow up comment to vector corruption check

What is the issue

Fixes: https://github.com/riptano/cndb/issues/14477

What does this PR fix and why was it fixed

This PR leverages the existing SAI verification framework and wires it up to validate components.

- **CNDB-14477: Validate SAI Components in Verifier**
- **Add follow up comment to vector corruption check**

### What is the issue
Fixes: riptano/cndb#14477

### What does this PR fix and why was it fixed
This PR leverages the existing SAI verification framework and wires it
up to the `Verifier` logic in the code compaction code.
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Jul 17, 2025

In 5.0 there is no Verifier and validation is done on the Index.Group interface, so this was added to StorageAttachedIndexGroup instead.

@driftx driftx requested a review from djatnieks July 17, 2025 21:11
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1889 rejected by Butler


37 new test failure(s) in 1 builds
See build details here


Found 37 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
...lidation.operations.AlterTest-compression_jdk11 regression 🔴
...nQueryShouldNotTimeoutWhenItExceedesReadTimeout regression 🔴
...nglePageReadIsFastButAggregationExceedesTimeout regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDBTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDCTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportEBTest.testANN regression 🔴
...c.FeaturesVersionSupportTest.testANNSupport[eb] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[aa] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[ba] regression 🔴
....s.f.SnapshotTest.shouldTakeAndRestoreSnapshots regression 🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴

No known test failures found

@driftx driftx merged commit 7170334 into main-5.0 Jul 18, 2025
568 of 591 checks passed
@driftx driftx deleted the CNDB-14845 branch July 18, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants