Skip to content

CNDB-14847 CC5 Restore SSTableFormat.requireComponents method #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

djatnieks
Copy link

What is the issue

Fixes CNDB-14847, restoring SSTableFormat.requiredComponents method

What does this PR fix and why was it fixed

Restores SSTableFormat.requiredComponents method to provide a list of expected components used in CNDB.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks djatnieks requested a review from driftx July 18, 2025 00:40
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1890 rejected by Butler


37 new test failure(s) in 1 builds
See build details here


Found 37 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
...lidation.operations.AlterTest-compression_jdk11 regression 🔴
...nQueryShouldNotTimeoutWhenItExceedesReadTimeout regression 🔴
...nglePageReadIsFastButAggregationExceedesTimeout regression 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴
o.a.c.d.t.r.ForceRepairTest.force regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDBTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDCTest.testANN regression 🔴
o.a.c.d.t.s.f.FeaturesVersionSupportEBTest.testANN regression 🔴
...c.FeaturesVersionSupportTest.testANNSupport[eb] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[aa] regression 🔴
....FeaturesVersionSupportTest.testGeoDistance[ba] regression 🔴
....s.f.SnapshotTest.shouldTakeAndRestoreSnapshots regression 🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴

No known test failures found

@djatnieks djatnieks merged commit 0c2d619 into main-5.0 Jul 18, 2025
565 of 589 checks passed
@djatnieks djatnieks deleted the CNDB-14847 branch July 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants