Skip to content

CNDB-14848 CC5 remove unused duplicated constants from SchemaConstants #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

djatnieks
Copy link

What is the issue

Fixes CNDB-14848, removing unused, duplicated constants from SchemaConstants

What does this PR fix and why was it fixed

SchemaConstants contains unused and duplicated constants left over from previous rebases.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks djatnieks assigned djatnieks and unassigned djatnieks Jul 18, 2025
@djatnieks djatnieks requested a review from driftx July 18, 2025 00:41
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1891 rejected by Butler


36 new test failure(s) in 2 builds
See build details here


Found 36 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
...lidation.operations.AlterTest-compression_jdk11 regression 🔴🔴
...nQueryShouldNotTimeoutWhenItExceedesReadTimeout regression 🔴🔴
...nglePageReadIsFastButAggregationExceedesTimeout regression 🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 regression 🔴🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 regression 🔴🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE regression 🔴🔴
...thRestartTest.testReadingValuesOfDroppedColumns regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDBTest.testANN regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportDCTest.testANN regression 🔴🔴
o.a.c.d.t.s.f.FeaturesVersionSupportEBTest.testANN regression 🔴🔴
...c.FeaturesVersionSupportTest.testANNSupport[eb] regression 🔴🔴
....FeaturesVersionSupportTest.testGeoDistance[aa] regression 🔴🔴
....FeaturesVersionSupportTest.testGeoDistance[ba] regression 🔴🔴
....s.f.SnapshotTest.shouldTakeAndRestoreSnapshots regression 🔴🔴
...cySSTableTest.testVerifyOldDroppedTupleSSTables regression 🔴🔴

Found 1 known test failures

@djatnieks djatnieks merged commit 1f3e8d3 into main-5.0 Jul 18, 2025
560 of 585 checks passed
@djatnieks djatnieks deleted the CNDB-14848 branch July 18, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants