Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Oct 15, 2025

Add defensive checks in SSTableWriter and SSTableReader to handle closed channels and null file handles when creating shallow readers during flush error recovery.

SSTableWriter: Catch IllegalStateException on file pointer access
SSTableReader: Handle null dfile in bytesOnDisk()

Add defensive checks in SSTableWriter and SSTableReader to handle
closed channels and null file handles when creating shallow readers
during flush error recovery.

SSTableWriter: Catch IllegalStateException on file pointer access
SSTableReader: Handle null dfile in bytesOnDisk()
@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks
Copy link

I think the test regressions are probably unrelated - I'll trigger another build to check

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the second PR build the tests look good to me.

@driftx driftx merged commit c688745 into main-5.0 Oct 16, 2025
581 of 593 checks passed
@driftx driftx deleted the CNDB-15697 branch October 16, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants