Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Oct 16, 2025

What is the issue

Paxos v2 doesn't have sensors

What does this PR fix and why was it fixed

Register sensors in paxos v2

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2070 rejected by Butler


49 regressions found
See build details here


Found 49 new test failures

Showing only first 15 new test failures

Test Explanation Runs Upstream
junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASContentionTest-_jdk11 REGRESSION 🔵🔴 0 / 11
junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASTest-_jdk11 REGRESSION 🔵🔴 0 / 11
junit.framework.TestSuite.org.apache.cassandra.distributed.test.CasWriteTest-_jdk11 REGRESSION 🔵🔴 0 / 11
junit.framework.TestSuite.org.apache.cassandra.distributed.test.LegacyCASTest-_jdk11 REGRESSION 🔵🔴 0 / 11
junit.framework.TestSuite.org.apache.cassandra.distributed.test.metrics.RequestTimeoutTest-_jdk11 REGRESSION 🔵🔴 0 / 11
test_unicode.TestCqlshUnicode.test_unicode_desc (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔵 0 / 11
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 11
o.a.c.distributed.test.CASContentionTest.testDynamicContentionTracing REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASMultiDCTest.testDcLocalCommitDisabled REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASMultiDCTest.testLocalSerialLocalCommit REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASMultiDCTest.testLocalSerialQuorumCommit REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASMultiDCTest.testSerialLocalCommit REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASMultiDCTest.testSerialQuorumCommit REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASTest.incompleteCommit REGRESSION 🔵🔴 0 / 11
o.a.c.distributed.test.CASTest.testRepairIncompletePropose REGRESSION 🔵🔴 0 / 11

Found 5 known test failures

@michaelsembwever
Copy link
Member

are there existing tests to cover/assert this ?

@driftx
Copy link
Author

driftx commented Oct 17, 2025

There's at least WriteMetricsTest#testLWTSensorMetrics which brought me here :)

@driftx driftx merged commit ef045eb into main-5.0 Oct 17, 2025
577 of 590 checks passed
@driftx driftx deleted the CNDB-15716 branch October 17, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants