CNDB-15701: Forbid creating vector indexes if version is earlier than CA #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Looks good to me.
This is exactly the change I expected
When you make the patch for CNDB , can you please add an assertion in this place:
pleasehttps://github.com/riptano/cndb/blob/main/cndb-test/src/test/java/com/datastax/cndb/integration/sai/AbstractMultiSAIVersions.java#L228
if (!not has vector) ... try to create the index .... assert that an error is returned and that the error contains the expected message ?
These index creations would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.
adelapena
force-pushed
the
CNDB-15701-main
branch
from
e905422 to
75f0d61
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2071 rejected by Butler2 regressions found Found 2 new test failures
No known test failures found |
michaelsembwever
pushed a commit
that referenced
this pull request
Oct 28, 2025
… CA (#2071) Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.
michaelsembwever
pushed a commit
that referenced
this pull request
Oct 28, 2025
…earlier than CA (#2071) Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.
michaelsembwever
pushed a commit
that referenced
this pull request
Nov 13, 2025
…earlier than CA (#2071) Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.
michaelsembwever
pushed a commit
that referenced
this pull request
Nov 13, 2025
…earlier than CA (#2071) Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Vector index creation when index version is earlier than
Version.JVECTOR_EARLIEST(CA) fail asynchronously. We want to validateCREATE INDEXstatements against the local index version so we can make these statement fail synchronously, before the index build is started and the schema is altered.What does this PR fix and why was it fixed
This patch makes vector index creation statements fail depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.