Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15885

What is the issue

There's a problem impacting all main-5.0 jvm-dtest-upgrade, as the run-tests.sh script it builds dtest-5.0.4.0.jar and then from the apache/cassandra cassandra-5.0 branch builds dtest-5.0.7.jar. Many of the jvm-dtest upgrade tests only perform upgrades to the CURRENT version which is the latest found, and that's the dtest-5.0.7.jar so the dtest-5.0.4.0.jar (and all working code changes) gets ignored.

I don't know where/how CC jenkins runs the jvm-dtest-upgrade testsuite, but this happens when doing it like

.build/run-tests.sh -a jvm-dtest-upgrade

What does this PR fix and why was it fixed

The fix is .build/run-tests.sh:202 needs to remove "cassandra-5.0"

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@driftx driftx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment so it doesn't look like it's just missing to the next person who notices it.

There's a problem impacting all main-5.0 jvm-dtest-upgrade, as the run-tests.sh script it builds dtest-5.0.4.0.jar and then from the apache/cassandra cassandra-5.0 branch builds dtest-5.0.7.jar. Many of the jvm-dtest upgrade tests only perform upgrades to the CURRENT version which is the latest found, and that's the dtest-5.0.7.jar so the dtest-5.0.4.0.jar (and all working code changes) gets ignored.

I don't know where/how CC jenkins runs the jvm-dtest-upgrade testsuite, but this happens when doing it like
```
.build/run-tests.sh -a jvm-dtest-upgrade
```
The fix is .build/run-tests.sh:202 needs to remove "cassandra-5.0"
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2096 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
paxos_test.TestPaxos.test_contention_many_threads (offheap-bti) REGRESSION 🔴🔵 0 / 14
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 14
o.a.c.distributed.test.RepairErrorsTest.testNoSuchRepairSessionAnticompaction REGRESSION 🔵🔴 0 / 14
o.a.c.index.sai.cql.VectorLocalTest.randomizedBqCompressedTest[ec] (compression) REGRESSION 🔴🔵 0 / 14

Found 5 known test failures

@michaelsembwever
Copy link
Member Author

Looks like CC jenkins can only run jvm-dtest-upgrade on java8.
see in jenkins-pipeline-lib src/com/datastax/jenkins/stargazer/DSCassandraBuild.groovy:216

I think that means we're missing coverage…?

@michaelsembwever michaelsembwever merged commit 38ae506 into main-5.0 Nov 3, 2025
575 of 590 checks passed
@michaelsembwever michaelsembwever deleted the mck-cndb-15885-main-5.0 branch November 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants