Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15898

Port into main-5.0 commit cd21102

CNDB-15898: CNDB-15745: Supports immutable components for SAI AA version (#2079)

Updates the file formatting methods for SAI `Version.AA` to handle the generation used by immutable components, enabling the option to use immutable components with version AA.

This also add a new `cassandra.sai.immutable_components.min_version` system property that allows to defines the minimum verison starting from which the existing `cassandra.sai.immutable_components` option will apply. As of this patch, this defaults to `ca`, because it is the behavior before this patch, but it can change to `aa` to allow using immutable components with `Version.AA`.

Fixes https://github.com/riptano/cndb/issues/15745.

…ion (#2079)

Updates the file formatting methods for SAI `Version.AA` to handle the
generation used by immutable components, enabling the option to use
immutable components with version AA.

This also add a new `cassandra.sai.immutable_components.min_version`
system property that allows to defines the minimum verison starting from
which the existing `cassandra.sai.immutable_components` option will
apply. As of this patch, this defaults to `ca`, because it is the
behavior before this patch, but it can change to `aa` to allow using
immutable components with `Version.AA`.

Fixes riptano/cndb#15745.
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2106 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.db.compaction.unified.ShardedMultiWriterTest.testShardedCompactionWriter_threeShard[isReplicaAware=true] (compression) REGRESSION 🔴 0 / 15

Found 5 known test failures

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one new test failure reported by Butler passed for me locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants