Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Nov 5, 2025

What is the issue

PaxosCommit lacks sensors

What does this PR fix and why was it fixed

Instrument PaxosCommit, PaxosPrepare, and PaxosPropose to track read, write, and internode bytes. Reuse existing RequestSensors in StorageProxy to prevent sensor data loss during CAS operations.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx driftx changed the title CNDB-15911: add sensors to PaxosCommit CNDB-15911: Add sensor tracking for Paxos V2 operations Nov 6, 2025
Instrument PaxosCommit, PaxosPrepare, and PaxosPropose to track read,
write, and internode bytes. Reuse existing RequestSensors in
StorageProxy to prevent sensor data loss during CAS operations.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2107 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
paxos_test.TestPaxos.test_contention_many_threads (offheap-bti) REGRESSION 🔴🔵 0 / 15
o.a.c.cql3.SimpleQueryTest.test2ndaryIndexBug (compression) REGRESSION 🔴🔵 0 / 15
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 15
o.a.c.index.sai.cql.VectorBruteforceLocalTest.randomizedBqCompressedTest[ed] (compression) REGRESSION 🔴🔵 0 / 15

Found 8 known test failures

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test failures reported by butler passed locally for me: SimpleQueryTest, TestPaxos dtest, and VectorBruteForceLocalTest

@driftx driftx merged commit 548bfc6 into main-5.0 Nov 10, 2025
574 of 590 checks passed
@driftx driftx deleted the CNDB-15911 branch November 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants