CNDB-15621: expose approximateTimeUUID in ULIDBasedSSTableId #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
approved these changes
Nov 10, 2025
| this.approximateTimeUUID = TimeUUID.approximateFromULID(ulid); | ||
| } | ||
|
|
||
| public TimeUUID getApproximateTimeUUID() |
There was a problem hiding this comment.
We should add a comment and maybe a quick unit test
jasonstack
force-pushed
the
cndb-15621-main
branch
from
d2d1b5e to
97304b8
Compare
jasonstack
force-pushed
the
cndb-15621-main
branch
from
97304b8 to
38f77e3
Compare
|
✔️ Build ds-cassandra-pr-gate/PR-2113 approved by ButlerApproved by Butler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
#15621 expose TimeUUID from ULIDBasedSSTableId
What does this PR fix and why was it fixed
expose TimeUUID from ULIDBasedSSTableId