CNDB-15971: Only init ReadExecutionController's histogram when tracing on#2118
Merged
michaeljmarshall merged 3 commits intomainfrom Nov 13, 2025
Merged
CNDB-15971: Only init ReadExecutionController's histogram when tracing on#2118michaeljmarshall merged 3 commits intomainfrom
michaeljmarshall merged 3 commits intomainfrom
Conversation
Checklist before you submit for review
|
ekaterinadimitrova2
left a comment
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
Good catch! Nice to have some test as we mentioned in Slack. Let's see also what CI will say
|
The patch is ok on its own, we should decide whether we want the histogram at all, as mentioned. I do not have strong opinion. But I believe it is usage will be quite limited. |
ekaterinadimitrova2
approved these changes
Nov 12, 2025
ekaterinadimitrova2
left a comment
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
Approved but pending merged on CNDB PR opened. I did not find any?
Member
Author
|
Here it is https://github.com/riptano/cndb/pull/15986 |
Thanks, I think you need to rebase this branch as CNDB is missing the latest committed changes in datastax/cassandra |
|
✔️ Build ds-cassandra-pr-gate/PR-2118 approved by ButlerApproved by Butler |
eolivelli
approved these changes
Nov 13, 2025
michaelsembwever
pushed a commit
that referenced
this pull request
Nov 20, 2025
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram.
michaelsembwever
pushed a commit
that referenced
this pull request
Dec 9, 2025
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram.
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 6, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram.
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 10, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 11, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 12, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 14, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 16, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Feb 27, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 2, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 4, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
michaelsembwever
pushed a commit
that referenced
this pull request
Mar 5, 2026
… when tracing on (#2118) Fixes: riptano/cndb#15971 CNDB PR: riptano/cndb#15986 In #800, we added a histogram to the `ReadExecutionController` to track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled. Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram. (Rebase of commit 7723d2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes: https://github.com/riptano/cndb/issues/15971
CNDB PR: https://github.com/riptano/cndb/pull/15986
What does this PR fix and why was it fixed
In #800, we added a histogram to the
ReadExecutionControllerto track some metric, but it is only observed when tracing is enabled. I propose that instead of creating one and tracking for every query, we only do that when tracing is enabled.Perhaps we could remove the logic entirely, but this solution will likely take care of all performance concerns related to unnecessary allocations and unnecessary tracking when updating the histogram.