Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Nov 13, 2025

What is the issue

Fixes #15999

What does this PR fix and why was it fixed

Provides a method to get CF directories without checking if they are directories

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx driftx requested a review from djatnieks November 13, 2025 21:21
Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually add a comment to say that this method is used by CNDB and it is not to be removed.

Is it possible to add unit tests ? It may seem weird to add unit tests for such small changes but at least we don't lower our global score

@driftx driftx requested a review from eolivelli November 14, 2025 11:33
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2123 rejected by Butler


3 regressions found
See build details here


Found 3 new test failures

Test Explanation Runs Upstream
junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest-_jdk11 REGRESSION 🔴🔵 0 / 17
paxos_test.TestPaxos.test_contention_many_threads (offheap-bti) REGRESSION 🔴🔵 0 / 17
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 17

Found 4 known test failures

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driftx driftx merged commit c5b95ec into main-5.0 Nov 18, 2025
576 of 591 checks passed
@driftx driftx deleted the CNDB-15999 branch November 18, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants