Skip to content

Conversation

@michaeljmarshall
Copy link
Member

What is the issue

Fixes: https://github.com/riptano/cndb/issues/16051

What does this PR fix and why was it fixed

The SAI segment builder logic keeps track of bytes used by a segment builder to ensure proper flushing to prevent OOM. This change tracks the PQ and BQ vector byte utilization per insertion.

At the moment, the added test ensures coverage, but fails due to recall issues. I will investigate this before merging.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2144 rejected by Butler


3 regressions found
See build details here


Found 3 new test failures

Test Explanation Runs Upstream
o.a.c.db.compaction.unified.ShardedMultiWriterTest.testShardedCompactionWriter_threeShard[isReplicaAware=true] (compression) REGRESSION 🔴 0 / 19
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompactionTooManyHoles[eb false] NEW 🔴 0 / 19
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[dc false] REGRESSION 🔴 0 / 19

Found 2 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants