-
Notifications
You must be signed in to change notification settings - Fork 21
CNDB-16021: CNDB-15280: Remove user data from AbstractReadQuery.toCQLString #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
|
Overall looks good, but it seems the new |
test/distributed/org/apache/cassandra/distributed/test/SlowQueryLoggerTest.java
Outdated
Show resolved
Hide resolved
7917017 to
d544dba
Compare
bed2448 to
9629caf
Compare
4572192 to
69f7f6b
Compare
adelapena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1.
…String (#2038) Replace column values by '?' when converting internal read queries to CQL's SELECT queries, so user data don't end up in logs or any other unprotected place. CQL queries printed in tracing and user-facing errors still expose the unredacted data.
69f7f6b to
8fe7a33
Compare
|
failed tests not reproduced locally. ninja fix squashed in for check failure on |
|



https://github.com/riptano/cndb/issues/16021
Port into main-5.0 commit 4517338
Will be merged to
main-5.0aftermck-cndb-15760-main-5.0is merged.