CNDB-16135: reuse table directory from Directories into Descriptor #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
pcmanus
approved these changes
Dec 4, 2025
| { | ||
| assert version != null && directory != null && ksname != null && cfname != null && formatType.info.getLatestVersion().getClass().equals(version.getClass()); | ||
| this.version = version; | ||
| // toCanonical() returns a new instance most of the time in C*. Plugable FS may behave differently to reuse instance if nothing to canonicalize. |
There was a problem hiding this comment.
Nit: I'm unsure how useful that comment is, here, for someone that doesn't have the context of the issue we're solving here. I wonder if it's not more distracting. And File#toCanonical is just:
Path canonical = PathUtils.toCanonicalPath(toPath());
return canonical == path ? this : new File(canonical);
so one doesn't have to go far to see that there is circumstance where no new instances may be created, if one is explicitly wondering.
| * @param name the name of the sstable to parse | ||
| * @return a pair of the descriptor and component corresponding to the provided {@code file}. | ||
| * | ||
| * @throws IllegalArgumentException if the provided {@code file} does point to a valid sstable filename. This could |
There was a problem hiding this comment.
Nit: typo in the comment: if the provided {@code file} does *not* point to a valid sstable. The typo comes from the comment from the previous method, so let's fix both.
jasonstack
force-pushed
the
cndb-16135-main
branch
2 times, most recently
from
b328d75 to
1485b9c
Compare
jasonstack
force-pushed
the
cndb-16135-main
branch
from
1485b9c to
b2e1765
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2150 rejected by Butler2 regressions found Found 2 new test failures
Found 3 known test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
CNDB-16135: Descriptor uses different instances of
Path directoryfor the same table as constructor parameterWhat does this PR fix and why was it fixed
Use the table directory from
DirectoriesinDescriptoras constructor parameter .Descriptor#directoryis still different instance in C* due todirectory#toCanonical()which always creates new instance in local file system