Skip to content

Fix off-by-one assertion and catch UnknownIndexException#2154

Merged
driftx merged 1 commit intomain-5.0from
CNDB-16241
Dec 8, 2025
Merged

Fix off-by-one assertion and catch UnknownIndexException#2154
driftx merged 1 commit intomain-5.0from
CNDB-16241

Conversation

@driftx
Copy link

@driftx driftx commented Dec 5, 2025

What is the issue

When the guardrail index limit equals the number of excluded indexes (as in both are 1), the assertion 1 < 1 fails even though having exactly the maximum allowed should be valid.

What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Dec 5, 2025

Just noticed main has the same problem /cc @adelapena

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

cassci-bot commented Dec 5, 2025

✔️ Build ds-cassandra-pr-gate/PR-2154 approved by Butler

Approved by Butler
See build details here

@driftx driftx merged commit c6ebfc0 into main-5.0 Dec 8, 2025
569 of 593 checks passed
@driftx driftx deleted the CNDB-16241 branch December 8, 2025 12:27
michaelsembwever pushed a commit that referenced this pull request Feb 6, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
da06e85 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException
michaelsembwever pushed a commit that referenced this pull request Feb 10, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
113faca 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Feb 11, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
3f6a507 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Feb 12, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
f6ce783 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Feb 14, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
bdab077 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Feb 16, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
af82212 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Feb 27, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
4144a11 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
michaelsembwever pushed a commit that referenced this pull request Mar 2, 2026
@driftx @michaelsembwever
Fix off-by-one assertion and catch UnknownIndexException (#2154)
0c3ebdb 
### What is the issue

When the guardrail index limit equals the number of excluded indexes (as
in both are 1), the assertion 1 < 1 fails even though having exactly the
maximum allowed should be valid.

### What does this PR fix and why was it fixed

Fixes the assertion and catches UnknownIndexException

 (Rebase of commit c6ebfc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsembwever michaelsembwever michaelsembwever approved these changes

@djatnieks djatnieks Awaiting requested review from djatnieks

@adelapena adelapena Awaiting requested review from adelapena

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driftx @cassci-bot @michaelsembwever