Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Dec 8, 2025

When storage_compatibility_mode is set to CC_4 or CASSANDRA_4, ensure that commit logs, hints, batch logs, and paxos commits use VERSION_40 serialization format.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment about logging.

I also got unused import warnings when I build locally.

…et mode

When storage_compatibility_mode is set to CC_4 or CASSANDRA_4, ensure
that commit logs, hints, batch logs, and paxos commits use VERSION_40
serialization format.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@driftx driftx merged commit 176400e into main-5.0 Dec 10, 2025
567 of 595 checks passed
@driftx driftx deleted the CNDB-16249 branch December 10, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants