Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Dec 10, 2025

What is the issue

CNDB-16249 introduced currentStorageVersion() which returns raw messaging versions (e.g., 12 for VERSION_40) when storage_compatibility_mode is CC_4. However, HintsDescriptor uses its own version scheme (1, 2, 3 for 3.0, 4.0, 5.0).

What does this PR fix and why was it fixed

Add hintsVersionFromMessagingVersion() to translate messaging versions to hints versions, similar to CommitLogDescriptor.

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx driftx requested a review from djatnieks December 10, 2025 20:39
@driftx driftx merged commit e5a59b7 into main-5.0 Dec 10, 2025
574 of 594 checks passed
@driftx driftx deleted the CNDB-16267 branch December 10, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants